Skip to content
This repository has been archived by the owner on Mar 15, 2021. It is now read-only.

V1 properties data assemblies and stimulus sets #33

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

tiagogmarques
Copy link
Contributor

Added code to generate assemblies and stimuli related to V1 properties benchmark in mkgu_packaging/dicarlo/marques

Assembly for preferred orientation benchmark based on DeValois et al 1982a
Assembly for multiple orientation and magnitude related benchmarks based on Ringach et al 2002
Stimulus sets to be used for orientation, magnitude, spatial frequency and size tuning benchmarks

Method to correct images in the movshon stimulus set by adding a cosine aperture

main function should be run two times, one for each stimulus set: access='public' and access='target'
saves converted image in a new folder given by the target_dir

returns the converted StimulusSet with the new image_paths and new stimuli_id (with -aperture added in the end)

Can be run in the command line with arparse and passing the access and target_dir parameters
# Conflicts:
#	mkgu_packaging/movshon/aperture_correct.py
…s benchmark in mkgu_packaging/dicarlo/marques

Assembly for preferred orientation benchmark based on DeValois et al 1982a
Assembly for multiple orientation and magnitude related benchmarks based on Ringach et al 2002
Stimulus sets to be used for orientation, magnitude, spatial frequency and size tuning benchmarks
mkgu_packaging/dicarlo/marques/marques_devalois1982a.py Outdated Show resolved Hide resolved
mkgu_packaging/dicarlo/marques/marques_devalois1982a.py Outdated Show resolved Hide resolved
mkgu_packaging/dicarlo/marques/marques_gen_stim.py Outdated Show resolved Hide resolved
mkgu_packaging/dicarlo/marques/marques_gen_stim.py Outdated Show resolved Hide resolved
mkgu_packaging/dicarlo/marques/marques_stim_common.py Outdated Show resolved Hide resolved
mkgu_packaging/dicarlo/marques/marques_ringach2002.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved

stim = Stimulus(size_px=[size_px, size_px], type_name='blank_stim', save_dir=save_dir, stim_id=0)

stimuli = pd.DataFrame({'image_id': str(0), 'degrees': [degrees]})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by the 'degrees' here -- at this point it's just pixels no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is actually redundant but see below.

Copy link
Member

@mschrimpf mschrimpf Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably delete 'degrees' from here then, if there's no connection to degrees at this point


stim = Stimulus(size_px=[size_px, size_px], type_name='blank_stim', save_dir=save_dir, stim_id=0)

stimuli = pd.DataFrame({'image_id': str(0), 'degrees': [degrees]})
Copy link
Member

@mschrimpf mschrimpf Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably delete 'degrees' from here then, if there's no connection to degrees at this point

mkgu_packaging/dicarlo/marques/marques_devalois1982a.py Outdated Show resolved Hide resolved
Added spatial frequency data assemblies
@mschrimpf
Copy link
Member

will wait with merge until the corresponding PR in github.com/brain-score/brainio_collection/ is up

Added spatial frequency, surround modulatio, and texture assemblies for V1 properties benchmarks
… for all the cells in eccentricities under 5deg and not just the central 1deg (DeValois1982a)

- Same as before but for the peak spatial frequency empirical distribution (DeValois1982b)
- Added sample variance and family variance to the empirical distributions (FreemanZiemba2013)
- Changed grating stimulus generation procedure to allow generation of specific combinations of parameters instead of all possible combinations (this allows dependences of parameters, for example size and spatial frequency)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants